Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update naming and add namespaces #74

Merged
merged 5 commits into from
Mar 19, 2020
Merged

Update naming and add namespaces #74

merged 5 commits into from
Mar 19, 2020

Conversation

TerenceJefferies
Copy link
Contributor

🆕 Update the entire package to support namespacing.

🔧 Remove support for anything under PHP 7.1

📁 Separate code into class files.

Remove snake casing in many places, add namespaces to the project.
@tomhazledine
Copy link
Contributor

Hi @TerenceJefferies, thanks for this PR. Namespacing has been on the to-do list for a while, so really great to see this added. And we're all glad to see the back of 5.6 😄Your refactoring of the codebase is a big step forward.

Couple of requests before merging, though:

  1. Your changes are breaking the CI. Would you be able to take a look? Everything works okay locally (tests pass, code runs, etc.) but it would be great to fix whatever the issue is here
  2. There has been a new release (v0.29.0) and it would be great to have those additions merged here.

@tomhazledine tomhazledine self-requested a review March 18, 2020 11:26
@TerenceJefferies
Copy link
Contributor Author

Hey @tomhazledine no problem at all, I've sorted all of that out now, merged the latest changes and sorted out the build 👍

Copy link
Contributor

@tomhazledine tomhazledine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work @TerenceJefferies - feels good to push this SDK over the line into v1.

@tomhazledine tomhazledine merged commit dd85b27 into cronofy:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants