Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use feature(const_fn_trait_bound) instead of feature(const_fn) #692

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Use feature(const_fn_trait_bound) instead of feature(const_fn) #692

merged 1 commit into from
Apr 30, 2021

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Apr 30, 2021 

error[E0658]: trait bounds other than `Sized` on const fn parameters are unstable
   --> crossbeam-epoch/src/atomic.rs:313:6
    |
313 | impl<T: ?Sized + Pointable> Atomic<T> {
    |      ^
    |
    = note: see issue #57563 <https://github.com/rust-lang/rust/issues/57563> for more information
    = help: add `#![feature(const_fn_trait_bound)]` to the crate attributes to enable

@taiki-e
Use feature(const_fn_trait_bound) instead of feature(const_fn)
584bb2e 
    error[E0658]: trait bounds other than `Sized` on const fn parameters are unstable
       --> crossbeam-epoch/src/atomic.rs:313:6
        |
    313 | impl<T: ?Sized + Pointable> Atomic<T> {
        |      ^
        |
        = note: see issue #57563 <rust-lang/rust#57563> for more information
        = help: add `#![feature(const_fn_trait_bound)]` to the crate attributes to enable
taiki-e
taiki-e commented Apr 30, 2021
View reviewed changes
Copy link
Member Author

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

See also rust-lang/rust#84510, rust-lang/rust#84556

@bors
Copy link
Contributor

bors bot commented Apr 30, 2021

Build succeeded:

@bors bors bot merged commit c093db3 into master Apr 30, 2021
@bors bors bot deleted the const_fn_trait_bound branch April 30, 2021 12:30
@taiki-e taiki-e mentioned this pull request May 29, 2021
Merged
bors bot added a commit that referenced this pull request May 30, 2021
@bors @taiki-e
Merge #707
6d4cdd4 
707: Prepare for the next release r=taiki-e a=taiki-e

- crossbeam-epoch 0.9.4 -> 0.9.5
  - Fix UB in `Pointable` impl of `[MaybeUninit<T>]` (#694)
  - Support targets that do not have atomic CAS on stable Rust (#698)
  - Fix breakage with nightly feature due to rust-lang/rust#84510 (#692)
- crossbeam-queue 0.3.1 -> 0.3.2
  - Support targets that do not have atomic CAS on stable Rust (#698)
- crossbeam-utils 0.8.4 -> 0.8.5
  - Add `AtomicCell::fetch_update` (#704)
  - Support targets that do not have atomic CAS on stable Rust (#698)
- crossbeam 0.8.0 -> 0.8.1
  - Support targets that do not have atomic CAS on stable Rust (#698)

Closes #702 

Co-authored-by: Taiki Endo <te316e89@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
crossbeam-epoch
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@taiki-e