Skip to content

Commit

Permalink
fix(rdsinstance): Updates will now set ResourceCredentialsSecretUserK…
Browse files Browse the repository at this point in the history
…ey in ConnectionDetails if masterUsername is set

Signed-off-by: Trystan Leftwich <trystanleftwich@gmail.com>
  • Loading branch information
trystanleftwich committed Feb 14, 2024
1 parent f759905 commit 2e35876
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions pkg/controller/database/rdsinstance/rdsinstance.go
Original file line number Diff line number Diff line change
Expand Up @@ -277,12 +277,18 @@ func (e *external) Update(ctx context.Context, mg resource.Managed) (managed.Ext
return managed.ExternalUpdate{}, err
}
if changed {
conn = managed.ConnectionDetails{
xpv1.ResourceCredentialsSecretPasswordKey: []byte(pwd),
}
conn = managed.ConnectionDetails{xpv1.ResourceCredentialsSecretPasswordKey: []byte(pwd)}
modify.MasterUserPassword = aws.String(pwd)
}

if cr.Spec.ForProvider.MasterUsername != nil {
if conn != nil {
conn[xpv1.ResourceCredentialsSecretUserKey] = []byte(aws.ToString(cr.Spec.ForProvider.MasterUsername))
} else {
conn = managed.ConnectionDetails{xpv1.ResourceCredentialsSecretUserKey: []byte(aws.ToString(cr.Spec.ForProvider.MasterUsername))}
}
}

if _, err = e.client.ModifyDBInstance(ctx, modify); err != nil {
return managed.ExternalUpdate{}, errorutils.Wrap(err, errModifyFailed)
}
Expand Down

0 comments on commit 2e35876

Please sign in to comment.