bug with external name firehose fixed

crossplane-contrib · Oct 17, 2023 · 9e4b850 · 9e4b850
1 parent 70d489d
commit 9e4b850
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/examples/firehose/deliverystream.yaml b/examples/firehose/deliverystream.yaml
@@ -6,7 +6,7 @@ spec:
   forProvider:
     region: us-east-1
     deliveryStreamName: firehose-deliverystream
-    deliveryStreamType: KinesisStreamAsSource
+    deliveryStreamType: DirectPut
     extendedS3DestinationConfiguration:
       roleARN: arn:aws:iam::000000000000:role/Firehose-Example-Role
       bucketARN: arn:aws:s3:::bucket-example

diff --git a/pkg/controller/firehose/deliverystream/setup.go b/pkg/controller/firehose/deliverystream/setup.go
@@ -58,6 +58,10 @@ func SetupDeliveryStream(mgr ctrl.Manager, o controller.Options) error {
 
 	reconcilerOpts := []managed.ReconcilerOption{
 		managed.WithExternalConnecter(&connector{kube: mgr.GetClient(), opts: opts}),
+		managed.WithReferenceResolver(managed.NewAPISimpleReferenceResolver(mgr.GetClient())),
+		managed.WithInitializers(
+			managed.NewDefaultProviderConfig(mgr.GetClient()),
+			managed.NewNameAsExternalName(mgr.GetClient())),
 		managed.WithPollInterval(o.PollInterval),
 		managed.WithLogger(o.Logger.WithValues("controller", name)),
 		managed.WithRecorder(event.NewAPIRecorder(mgr.GetEventRecorderFor(name))),
@@ -121,6 +125,5 @@ func postCreate(_ context.Context, cr *svcapitypes.DeliveryStream, obj *svcsdk.C
 	if err != nil {
 		return managed.ExternalCreation{}, err
 	}
-	meta.SetExternalName(cr, cr.Name)
 	return managed.ExternalCreation{ExternalNameAssigned: true}, nil
 }