DynamoDB: Add PointInTimeRecoveryEnabled

[duncaan]

What problem are you facing?

There is no way to set the PointInTimeRecoveryEnabled value on a dynamodb table or backup. This is possible through the AWS SDK: https://docs.aws.amazon.com/sdk-for-go/api/service/dynamodb/#PointInTimeRecoverySpecification

How could Crossplane help solve your problem?

Allow the dynamodb table or backup CRD to allow setting PointInTimeRecoveryEnabled to true or false

[duncaan]

Looked a little deeper and seems that the PITR was enabled with this PR: https://github.com/aws/aws-sdk-go/pull/1864/files but unsure why it isn't being generated by https://github.com/crossplane/provider-aws/blob/master/CODE_GENERATION.md

[duncaan]

@muvaf - Is this anything you might know about?

[hasheddan]

@duncaan looks like this field is not generated because it can't actually be set at table creation (https://docs.aws.amazon.com/sdk-for-go/api/service/dynamodb/#CreateTableInput). We will likely need to add a ContinuousBackups resource as a standalone type that references a Table object, or incorporate it into the table spec https://docs.aws.amazon.com/sdk-for-go/api/service/dynamodb/#UpdateContinuousBackupsInput

[jdfalk]

It seems like this would be pretty easy to implement if you do something like you do in the security groups. Can something like that be implemented, where you make two calls one immediately after the other on create?

https://github.com/crossplane/provider-aws/blob/97f0753230fbe2de63d234364827178d5ec1876f/pkg/controller/ec2/securitygroup/controller.go#L180-L181

[muvaf]

We can have this PointInTimeRecoverySpecification struct in CustomTableParameters and make the UpdateContinuousBackups call in setup.go during Update.

[github-actions]

Crossplane does not currently have enough maintainers to address every issue and pull request. This issue has been automatically marked as stale because it has had no activity in the last 90 days. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.