-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Observe Only Resources #1744
Conversation
@chlunde awesome - what are the openpoints because of Draft ? |
@haarchri I was waiting for what @turkenh would do with crossplane-contrib/provider-gcp#503, as I just mechanically reproduced his changes :) @turkenh what are your thoughts? |
@chlunde I don't expect further changes and just waiting for an approval there. |
so @chlunde can we rebase ? lookd great |
@haarchri I think we should wait for crossplane/crossplane-runtime#456 |
Great piece of work! Would be really great to have this :) |
go get github.com/crossplane/crossplane-tools@master go mod tidy make generate # failed go get github.com/crossplane/crossplane-runtime@master go mod tidy make generate # retry, OK https://github.com/upbound/upjet/blob/main/docs/adding-support-for-observe-only.md Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
Fixes crossplane-contrib#1726 hacked using emacs: for f in $(grep -lr 'func Setup' pkg/controller/ ); do emacs --load refactor.el "$f"; done refactor.el: (defun last-macro () (interactive) (atomic-change-group (search-forward "func Setup") (search-forward "managed.NewReconciler") (search-backward "m") (set-mark-command nil) (search-forward "(") (left-char 1) (forward-sexp 1 (point)) (kill-region nil nil 'region) (insert "r") (search-backward "return") (previous-line 1 1) (end-of-line) (newline nil 1) (insert "r := ") (yank nil) (newline nil 1) (search-backward "r := ") (search-forward "resource.ManagedKind") (forward-sexp 1 (point)) (move-end-of-line 1) (newline nil 1) (insert "reconcilerOpts...") (set-mark-command nil) (search-backward "managed.NewReconciler") (search-forward "(") (left-char 1) (forward-sexp 1 (point)) (left-char 1) (kill-region nil nil 'region) (search-backward "r :=") (previous-line 1 1) (insert " reconcilerOpts := []managed.ReconcilerOption{") (yank nil) (insert ", } ") (insert "if o.Features.Enabled(features.EnableAlphaManagementPolicies) { reconcilerOpts = append(reconcilerOpts, managed.WithManagementPolicies()) } ") (goto-line 1) (search-forward "github.com/crossplane-contrib/provider-aws") (end-of-line) (insert "\n\"github.com/crossplane-contrib/provider-aws/pkg/features\"") (save-buffer 1) )) (add-hook 'go-mode-hook #'last-macro) Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
@chlunde i made two commits, rebased onto the master branch, and updated crossplane-runtime and crossplane-tools to their latest versions for more precise management policies. I also tested the provider with some resources:
|
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
@haarchri nice! |
* crossplane-{tools,runtime}@master, go generate go get github.com/crossplane/crossplane-tools@master go mod tidy make generate # failed go get github.com/crossplane/crossplane-runtime@master go mod tidy make generate # retry, OK https://github.com/upbound/upjet/blob/main/docs/adding-support-for-observe-only.md Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no> * Add --enable-management-policies flag Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no> * Pass management policy flag to the controllers Fixes crossplane-contrib#1726 hacked using emacs: for f in $(grep -lr 'func Setup' pkg/controller/ ); do emacs --load refactor.el "$f"; done refactor.el: (defun last-macro () (interactive) (atomic-change-group (search-forward "func Setup") (search-forward "managed.NewReconciler") (search-backward "m") (set-mark-command nil) (search-forward "(") (left-char 1) (forward-sexp 1 (point)) (kill-region nil nil 'region) (insert "r") (search-backward "return") (previous-line 1 1) (end-of-line) (newline nil 1) (insert "r := ") (yank nil) (newline nil 1) (search-backward "r := ") (search-forward "resource.ManagedKind") (forward-sexp 1 (point)) (move-end-of-line 1) (newline nil 1) (insert "reconcilerOpts...") (set-mark-command nil) (search-backward "managed.NewReconciler") (search-forward "(") (left-char 1) (forward-sexp 1 (point)) (left-char 1) (kill-region nil nil 'region) (search-backward "r :=") (previous-line 1 1) (insert " reconcilerOpts := []managed.ReconcilerOption{") (yank nil) (insert ", } ") (insert "if o.Features.Enabled(features.EnableAlphaManagementPolicies) { reconcilerOpts = append(reconcilerOpts, managed.WithManagementPolicies()) } ") (goto-line 1) (search-forward "github.com/crossplane-contrib/provider-aws") (end-of-line) (insert "\n\"github.com/crossplane-contrib/provider-aws/pkg/features\"") (save-buffer 1) )) (add-hook 'go-mode-hook #'last-macro) Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no> * feat(bump): bump crossplane-runtime and crospslane-tools Signed-off-by: Christopher Haar <christopher.haar@upbound.io> * feat(bump): rebase and bump Signed-off-by: Christopher Haar <christopher.haar@upbound.io> * feat(bump): set up_version v0.18.0 to fits build module Signed-off-by: Christopher Haar <christopher.haar@upbound.io> * feat(bump): set golangci_version to v1.53.3 Signed-off-by: Christopher Haar <christopher.haar@upbound.io> --------- Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no> Signed-off-by: Christopher Haar <christopher.haar@upbound.io> Co-authored-by: Christopher Haar <christopher.haar@upbound.io>
* crossplane-{tools,runtime}@master, go generate go get github.com/crossplane/crossplane-tools@master go mod tidy make generate # failed go get github.com/crossplane/crossplane-runtime@master go mod tidy make generate # retry, OK https://github.com/upbound/upjet/blob/main/docs/adding-support-for-observe-only.md Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no> * Add --enable-management-policies flag Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no> * Pass management policy flag to the controllers Fixes crossplane-contrib#1726 hacked using emacs: for f in $(grep -lr 'func Setup' pkg/controller/ ); do emacs --load refactor.el "$f"; done refactor.el: (defun last-macro () (interactive) (atomic-change-group (search-forward "func Setup") (search-forward "managed.NewReconciler") (search-backward "m") (set-mark-command nil) (search-forward "(") (left-char 1) (forward-sexp 1 (point)) (kill-region nil nil 'region) (insert "r") (search-backward "return") (previous-line 1 1) (end-of-line) (newline nil 1) (insert "r := ") (yank nil) (newline nil 1) (search-backward "r := ") (search-forward "resource.ManagedKind") (forward-sexp 1 (point)) (move-end-of-line 1) (newline nil 1) (insert "reconcilerOpts...") (set-mark-command nil) (search-backward "managed.NewReconciler") (search-forward "(") (left-char 1) (forward-sexp 1 (point)) (left-char 1) (kill-region nil nil 'region) (search-backward "r :=") (previous-line 1 1) (insert " reconcilerOpts := []managed.ReconcilerOption{") (yank nil) (insert ", } ") (insert "if o.Features.Enabled(features.EnableAlphaManagementPolicies) { reconcilerOpts = append(reconcilerOpts, managed.WithManagementPolicies()) } ") (goto-line 1) (search-forward "github.com/crossplane-contrib/provider-aws") (end-of-line) (insert "\n\"github.com/crossplane-contrib/provider-aws/pkg/features\"") (save-buffer 1) )) (add-hook 'go-mode-hook #'last-macro) Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no> * feat(bump): bump crossplane-runtime and crospslane-tools Signed-off-by: Christopher Haar <christopher.haar@upbound.io> * feat(bump): rebase and bump Signed-off-by: Christopher Haar <christopher.haar@upbound.io> * feat(bump): set up_version v0.18.0 to fits build module Signed-off-by: Christopher Haar <christopher.haar@upbound.io> * feat(bump): set golangci_version to v1.53.3 Signed-off-by: Christopher Haar <christopher.haar@upbound.io> --------- Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no> Signed-off-by: Christopher Haar <christopher.haar@upbound.io> Co-authored-by: Christopher Haar <christopher.haar@upbound.io>
Description of your changes
commits:
Fixes #1726
I have:
make reviewable test
to ensure this PR is ready for review.I got "too many open files" for make reviewable, so I'll check CI.
How has this code been tested
Not yet tested in any way.