Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(route53): hostedzone tags related api calls #1846

Merged

Conversation

wotolom
Copy link
Contributor

@wotolom wotolom commented Aug 22, 2023

Description of your changes

  • provide HostedZoneID without prefix "/hostedzone/" when using tag related API Calls (ListTagsForResource and ChangeTagsForResource)
  • adapt logic to fill ChangeTagsForResourceInput to avoid AWS error, when providing empty tag lists in request

Fixes #1826
strange error because AWS API Docs actually mentions an 64 length constraint for resourceId and not 32 (prefix + id = 33)

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

manually

Signed-off-by: Charel Baum (external expert on behalf of DB Netz AG) <charel.baum-extern@deutschebahn.com>
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much for that fix @wotolom!

@MisterMX MisterMX merged commit 4c69e19 into crossplane-contrib:master Aug 28, 2023
8 checks passed
@wotolom wotolom deleted the fix-hostedzone-tagging-calls branch November 30, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HostedZone 0.42.0 1.13.1 resourceId Member must have length less than or equal to 32
2 participants