Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Readd empty initializers after runtime update #1942

Merged
merged 1 commit into from
Nov 10, 2023
Merged

fix: Readd empty initializers after runtime update #1942

merged 1 commit into from
Nov 10, 2023
+17 −4

Commits on Nov 9, 2023

  1. fix: Readd empty initializers after runtime update 

    The default behaviour of a controller is to use
`managed.NewNameWithExternalName`. Controllers need to pass
`managed.WithInitializers()` to change the behaviour.

After the runtime upgrade and tagging removal, some of the empty
`managed.WithInitializers()` got removed resulting in a different
behaviour.

Readd them restore the previous behaviour.

Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <maximilian.blatt-extern@deutschebahn.com>
    @MisterMX
    MisterMX committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    0ddc4ec View commit details
    Browse the repository at this point in the history