fix: take into consideration the DesiredCount/RunningCount for resource readiness #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnlopes
force-pushed
the
fix/ecs-ready-with-desired-count
branch
from
c9a377b
to
fe6b638
Compare
MisterMX
requested changes
Apr 8, 2024
dnlopes
force-pushed
the
fix/ecs-ready-with-desired-count
branch
from
430f7eb
to
e443005
Compare
MisterMX
requested changes
Apr 10, 2024
dnlopes
force-pushed
the
fix/ecs-ready-with-desired-count
branch
from
0e0b23b
to
085a7e3
Compare
MisterMX
requested changes
Apr 15, 2024
dnlopes
force-pushed
the
fix/ecs-ready-with-desired-count
branch
from
8e52fdd
to
2a933b0
Compare
…ce readiness Signed-off-by: David Lopes <me@davlopes.com>
MisterMX
force-pushed
the
fix/ecs-ready-with-desired-count
branch
from
2a933b0
to
1a1ce70
Compare
|
Successfully created backport PR #2044 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ECS Service resource is only taken into consideration the
.Statusfield to decide on the readiness of the Crossplane resource.I think this is an overlook, and Crossplane should also take into consideration the
DesiredCount/RunningCount, since it is part of the input Spec. Returning ready based only on the.Statusmight result in returning to the client a ready state when in fact, no tasks are running yet.Before wrapping up the PR with tests, I would like to get some feedback from you to undertstand if you agree with this change or not.
I have:
make reviewable testto ensure this PR is ready for review.Thanks.