Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sg): add more status atProvider for missing fields #2065

Merged
merged 2 commits into from
Jun 10, 2024
Merged

feat(sg): add more status atProvider for missing fields #2065

merged 2 commits into from
Jun 10, 2024

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Jun 3, 2024

Description of your changes

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

test & unittest

@haarchri
feat(sg): add more status atProvider for missing fields
afa755a 
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
@haarchri haarchri requested a review from MisterMX June 3, 2024 12:05
@haarchri
feat(sg): make generate
9bf9611 
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
MisterMX
MisterMX approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @haarchri!

@MisterMX MisterMX merged commit bad55db into crossplane-contrib:master Jun 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MisterMX MisterMX MisterMX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haarchri @MisterMX