feat(ec2): Add Ipv6Prefixe support to Instance #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaspahomov
force-pushed
the
feature/instance-ipv6-prefix
branch
from
ae1e9e9
to
01c6c72
Compare
muvaf
reviewed
Jan 29, 2022
vaspahomov
force-pushed
the
feature/instance-ipv6-prefix
branch
from
01c6c72
to
9251ac0
Compare
Signed-off-by: vaspahomov <vas2142553@gmail.com> Co-authored-by: Maximilian Blatt (external expert on behalf of DB Netz) <maximilian.blatt-extern@deutschebahn.com>
MisterMX
changed the title
MisterMX
force-pushed
the
feature/instance-ipv6-prefix
branch
from
9251ac0
to
027189d
Compare
MisterMX
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
It took some time but LGTM. I only made some slight adjustments. Thanks alot @vaspahomov!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vaspahomov vas2142553@gmail.com
Description of your changes
Support ec2.Instance creation with IpV6 prefix.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Cover new code with unit test. Manually tested Intance with ipv6 prefix creation