Do not issue update when diff is nil vs empty for either slices or maps #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
hasheddan
commented
Feb 13, 2020
| @@ -110,6 +110,7 @@ func GenerateDatabaseInstance(name string, in v1beta1.CloudSQLInstanceParameters | |||
| ExpirationTime: gcp.StringValue(val.ExpirationTime), | |||
| Name: gcp.StringValue(val.Name), | |||
| Value: gcp.StringValue(val.Value), | |||
| Kind: "sql#aclEntry", | |||
There was a problem hiding this comment.
Note: anywhere where we fully replace a struct when it is not nil, we need to make sure that we include all fields like this. I checked CloudMemorystore, GKECluster, and NodePool for similar issues and did not find any.
There was a problem hiding this comment.
ACLEntry. I think that might be a high level API resource that I was planning to implement a controller for during bucket stuff #137
There was a problem hiding this comment.
Though this PR is not the right place to do it right now. So, my comment is not blocking
muvaf
approved these changes
Feb 13, 2020
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
hasheddan
force-pushed
the
equateempty
branch
from
343a41e
to
9f4dbbb
Compare
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Description of your changes
Follow up on #166 that causes our comparison functions to treat all maps and slices with a length of zero to be equal, regardless of whether they are nil. I ran into a constantly updating instance that was being triggered by this check. I don't think it should cause any problems with needing an update when a slice or map has changed (i.e. if it either was of length zero or will be of length zero then it by definition had to change its length, meaning this check will produce a diff).
Checklist
I have:
make reviewableto ensure this PR is ready for review.app.yamlto include any new role permissions.