Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Rendering Patches #1

Closed
turkenh opened this issue Jul 23, 2020 · 0 comments
Closed

Post Rendering Patches #1

turkenh opened this issue Jul 23, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request hcp

Comments

@turkenh
Copy link
Collaborator

turkenh commented Jul 23, 2020

It should be possible to provide post rendering patches which will make last mile configurations using
post rendering option of Helm. spec.forProvider.patchesFrom
array will be used to specify patch definitions satisfying kustomizes patchTransformer interface.

Example:

patches:
- patch: |-
    - op: replace
      path: /some/existing/path
      value: new value
  target:
    kind: MyKind
    labelSelector: "env=dev"
- patch: |-
    - op: add
      path: /spec/template/spec/nodeSelector
      value:
        node.size: really-big
        aws.az: us-west-2a
  target:
    kind: Deployment
    labelSelector: "env=dev"

More context: crossplane/crossplane#1642 (comment)
Design doc: https://github.com/crossplane/crossplane/blob/master/design/one-pager-helm-provider.md#crossplane-helm-provider

@turkenh turkenh added the enhancement New feature or request label Jul 23, 2020
lukeweber added a commit that referenced this issue Aug 10, 2020
Add Kustomization patch support to helm3 post render hook, resolves #1
@lukeweber lukeweber added the hcp label Sep 3, 2020
@lukeweber lukeweber self-assigned this Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hcp
Projects
None yet
Development

No branches or pull requests

2 participants