Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce MR metrics #222

Merged
merged 2 commits into from
May 20, 2024

Conversation

ezgidemirel
Copy link
Contributor

Description of your changes

This change introduces MR metrics to provider-helm.

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Deployed the custom image to a cluster and verified the metrics

Ezgis-MacBook-Pro:phase-2 ezgidemirel$ curl -s http://localhost:8080/metrics |grep crossplane_
# HELP crossplane_managed_resource_exists The number of managed resources that exist
# TYPE crossplane_managed_resource_exists gauge
crossplane_managed_resource_exists{gvk="helm.crossplane.io/v1beta1, Kind=Release"} 10
# HELP crossplane_managed_resource_ready The number of managed resources in Ready=True state
# TYPE crossplane_managed_resource_ready gauge
crossplane_managed_resource_ready{gvk="helm.crossplane.io/v1beta1, Kind=Release"} 10
# HELP crossplane_managed_resource_synced The number of managed resources in Synced=True state
# TYPE crossplane_managed_resource_synced gauge
crossplane_managed_resource_synced{gvk="helm.crossplane.io/v1beta1, Kind=Release"} 10

Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
@ezgidemirel ezgidemirel requested a review from turkenh May 15, 2024 12:09
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Copy link
Collaborator

@turkenh turkenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ezgidemirel 🙌

@turkenh turkenh merged commit 17abd14 into crossplane-contrib:master May 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants