Add an event filter with the resource.DesiredStateChanged predicate to filter status updates out #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ulucinar
force-pushed
the
filter-status-updates
branch
from
f28575f
to
a493060
Compare
ulucinar
force-pushed
the
filter-status-updates
branch
3 times, most recently
from
ad69663
to
4ba8384
Compare
sergenyalcin
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Thanks @ulucinar I left two comments that are related to copy-paste.
config/kendra/config.go
Outdated
| "github.com/upbound/upjet/pkg/config" | ||
| ) | ||
|
|
||
| // Configure adds configurations for kafka group. |
There was a problem hiding this comment.
Suggested change
| // Configure adds configurations for kafka group. | |
| // Configure adds configurations for kendra group. |
There was a problem hiding this comment.
Thanks @sergenyalcin, done.
config/medialive/config.go
Outdated
| "github.com/upbound/upjet/pkg/config" | ||
| ) | ||
|
|
||
| // Configure adds configurations for kafka group. |
There was a problem hiding this comment.
Suggested change
| // Configure adds configurations for kafka group. | |
| // Configure adds configurations for medialive group. |
ulucinar
force-pushed
the
filter-status-updates
branch
from
4ba8384
to
37f8396
Compare
…o filter status updates out Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
force-pushed
the
filter-status-updates
branch
from
37f8396
to
cf56c7c
Compare
This was referenced Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds an event filter using the resource.DesiredStateChanged to the generated resource controllers so that updates to only labels, annotations (Crossplane's create pending/failed annotations will be ignored) and to the
specwill result in reconcile requests.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested with crossplane/upjet#231.