Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Pete Lumbis <pete@upbound.io>
  • Loading branch information
lsviben and plumbis authored Aug 2, 2023
1 parent 7e91f37 commit 99b6667
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
13 changes: 6 additions & 7 deletions content/knowledge-base/guides/import-existing-resources.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,22 +85,21 @@ managed resource `spec` changes the external resource.

## Import resources automatically

Automatically import external resources with the granular management polices
[`spec.managementPolicies: ["Observe"]`]({{<ref "/v1.13/concepts/managed-resources#managementpolicies">}}).
Automatically import external resources with an `Observe` [management policy]({{<ref "/v1.13/concepts/managed-resources#managementpolicies">}}).

Crossplane imports `Observe` only resources but never changes or deletes the
Crossplane imports observe only resources but never changes or deletes the
resources.

{{<hint "important" >}}
The managed resource `managementPolicies` option is an alpha feature.

Enable the `managementPolicies` in a provider with `--enable-management-policies`
Enable `managementPolicies` in a provider with `--enable-management-policies`
in a
[ControllerConfig]({{<ref "/v1.12/concepts/providers#controller-configuration" >}}).
{{< /hint >}}

<!-- vale off -->
### Apply the ["Observe"] managementPolicies
### Apply the Observe management policy
<!-- vale on -->

Create a new managed resource matching the
Expand Down Expand Up @@ -233,10 +232,10 @@ status:
## Control imported ObserveOnly resources
<!-- vale on -->

Crossplane can take active control of `ObserveOnly` imported resources by
Crossplane can take active control of observe only imported resources by
changing the `managementPolicies` after import.

Change the {{<hover label="fc" line="8">}}managementPolicy{{</hover>}} field
Change the {{<hover label="fc" line="8">}}managementPolicies{{</hover>}} field
of the managed resource to
{{<hover label="fc" line="8">}}["*"]{{</hover>}}.

Expand Down
2 changes: 1 addition & 1 deletion content/master/concepts/managed-resources.md
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ that if the field is already filled, the controller won't override its value.
{{<hint "important" >}}
The managed resource `managementPolicies` option is an alpha feature.

Enable the `managementPolicies` in a provider with `--enable-management-policies`
Enable `managementPolicies` in a provider with `--enable-management-policies`
in a
[ControllerConfig]({{<ref "./providers#controller-configuration" >}}).
{{< /hint >}}
Expand Down

0 comments on commit 99b6667

Please sign in to comment.