Updates the ControllerConfig deprecation warning #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now includes a link to the replacement solution design. Signed-off-by: Jean du Plessis <jean@upbound.io>
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jeanduplessis
commented
Sep 14, 2023
Comment on lines
+306
to
318
| ### Controller configuration | ||
|
|
||
| {{< hint "important" >}} | ||
| The Crossplane community deprecated the `ControllerConfig` type in v1.11. | ||
| Applying a Controller configuration generates a deprecation warning. | ||
| The Crossplane community deprecated the `ControllerConfig` type in v1.11 to | ||
| indicate that no further enhancements will be made to it. | ||
| Applying a Controller configuration generates a deprecation warning. | ||
|
|
||
| Controller configurations are still supported until there is a replacement type | ||
| in a future Crossplane version. | ||
| in a future Crossplane version. You can read more about the design of | ||
| [Package Runtime Config](https://github.com/crossplane/crossplane/blob/master/design/one-pager-package-runtime-config.md) | ||
| which will replace it in the future. | ||
|
|
||
| {{< /hint >}} |
There was a problem hiding this comment.
This is the relevant section for review
jeanduplessis
commented
Sep 14, 2023
Comment on lines
+307
to
318
| ### Controller configuration | ||
|
|
||
| {{< hint "important" >}} | ||
| The Crossplane community deprecated the `ControllerConfig` type in v1.11. | ||
| Applying a Controller configuration generates a deprecation warning. | ||
| The Crossplane community deprecated the `ControllerConfig` type in v1.11 to | ||
| indicate that no further enhancements will be made to it. | ||
| Applying a Controller configuration generates a deprecation warning. | ||
|
|
||
| Controller configurations are still supported until there is a replacement type | ||
| in a future Crossplane version. | ||
| in a future Crossplane version. You can read more about the design of | ||
| [Package Runtime Config](https://github.com/crossplane/crossplane/blob/master/design/one-pager-package-runtime-config.md) | ||
| which will replace it in the future. | ||
| {{< /hint >}} |
There was a problem hiding this comment.
This is the relevant section for review
jeanduplessis
commented
Sep 14, 2023
Comment on lines
+307
to
318
| ### Controller configuration | ||
|
|
||
| {{< hint "important" >}} | ||
| The Crossplane community deprecated the `ControllerConfig` type in v1.11. | ||
| Applying a Controller configuration generates a deprecation warning. | ||
| The Crossplane community deprecated the `ControllerConfig` type in v1.11 to | ||
| indicate that no further enhancements will be made to it. | ||
| Applying a Controller configuration generates a deprecation warning. | ||
|
|
||
| Controller configurations are still supported until there is a replacement type | ||
| in a future Crossplane version. | ||
| in a future Crossplane version. You can read more about the design of | ||
| [Package Runtime Config](https://github.com/crossplane/crossplane/blob/master/design/one-pager-package-runtime-config.md) | ||
| which will replace it in the future. | ||
| {{< /hint >}} |
There was a problem hiding this comment.
This is the relevant section for review
jeanduplessis
commented
Sep 14, 2023
Comment on lines
+306
to
317
| ### Controller configuration | ||
|
|
||
| {{< hint "important" >}} | ||
| The Crossplane community deprecated the `ControllerConfig` type in v1.11. | ||
| Applying a Controller configuration generates a deprecation warning. | ||
| The Crossplane community deprecated the `ControllerConfig` type in v1.11 to | ||
| indicate that no further enhancements will be made to it. | ||
| Applying a Controller configuration generates a deprecation warning. | ||
|
|
||
| Controller configurations are still supported until there is a replacement type | ||
| in a future Crossplane version. | ||
| in a future Crossplane version. You can read more about the design of | ||
| [Package Runtime Config](https://github.com/crossplane/crossplane/blob/master/design/one-pager-package-runtime-config.md) | ||
| which will replace it in the future. | ||
| {{< /hint >}} |
There was a problem hiding this comment.
This is the relevant section for review
5 tasks
plumbis
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now includes a link to the replacement solution design.
Urgh... unfortunately my document formatter removed all trailing space so there's a lot of noise in this diff. The relevant diff lines are 309:318