-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos in composition functions documentation #560
Fix typos in composition functions documentation #560
Conversation
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@mergenci looks like Vale prefers "general-purpose": https://github.com/crossplane/docs/actions/runs/6349618710/job/17457649897?pr=560#step:5:261 😓 |
@phisco did you mean Vale prefers “general purpose”, rather than “general-purpose”? Because, in the link you posted, I see a Crossplane.Spelling error for “general-purpose”. How shall I address the error? Shall I define an exception for “general-purpose” in spelling-exceptions.txt? Or, do nothing, because “general-purpose” is valid usage? By the way, I see more general problems in the Vale output:
Is there anything that we can do to address the above issues? |
Ah, I interpreted it the other way around, my bad, yes, it's complaining about the remaining occurrences of |
Thanks for the update! I'm good with the Vale errors as we haven't gotten this page to pass Vale yet, so we can treat it as an exception for now. |
I corrected two typos in composition functions documentation. Because composition functions documentation doesn't exist in v1.11 and v1.12, there are no changes in those directories.