Corrects usage of Trim Prefix/Suffix. #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pete Lumbis <pete@upbound.io>
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jbw976
reviewed
Apr 10, 2024
There was a problem hiding this comment.
Should this be fixed in master too?
https://github.com/crossplane/docs/blob/master/content/master/concepts/patch-and-transform.md
Signed-off-by: Pete Lumbis <pete@upbound.io>
|
🤦♂️ I fixed it and forgot to add it to the commit. Done. |
jbw976
reviewed
Apr 10, 2024
| The {{<hover label="typeRegex" line="8">}}type: TrimSuffix{{</hover>}} removes | ||
| the matching string and all proceeding characters. | ||
| The {{<hover label="typeTrimS" line="8">}}type: TrimSuffix{{</hover>}} uses | ||
| Go's [TrimSuffix](https://pkg.go.dev/strings#TrimPrefix) and removes characters |
There was a problem hiding this comment.
this should link to the TrimSuffix function - i think this problem exists for all versions
Signed-off-by: Pete Lumbis <pete@upbound.io>
phisco
approved these changes
Apr 10, 2024
jbw976
requested changes
Apr 11, 2024
Signed-off-by: Pete Lumbis <pete@upbound.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #747