Promote composition functions to v1

[negz]

Description of your changes

This PR compliments crossplane/crossplane#5885, which promotes functions to v1 in Crossplane.

Crossplane v1.17 and above will send requests to apiextensions.fn.proto.v1.FunctionRunnerService. It'll fall back to apiextensions.fn.proto.v1beta1.FunctionRunnerService if v1 isn't available. Crossplane v1.16 and earlier will only send requests to apiextensions.fn.proto.v1beta1.FunctionRunnerService.

Going forward we want functions to serve apiextensions.fn.proto.v1.FunctionRunnerService. However, to avoid breaking compatibility with Crossplane v1.16 and earlier they'll also need to serve apiextensions.fn.proto.v1beta1.FunctionRunnerService.

This PR:

• Updates the SDK to use v1 types.
• Adds a BetaServer middleware that serves v1beta1 requests by wrapping a v1 server.

This wrapping approach only works because we intend v1 to be identical to v1beta1. That is, we promoted v1beta1 to v1 without making any breaking changes. In upstream Crossplane the v1beta1 proto is now automatically replicated from the v1 proto to ensure they remain identical.

I have:

• Read and followed Crossplane's contribution process.
• Run make reviewable to ensure this PR is ready for review.

How has this code been tested

[blakeromano]

This looks good to me from what I can tell. Looks like the implementation of serve serving both v1beta1 and v1 seems fine. I can't think of any crazy performance implications by running both.

[negz]

I tested this by:

• Building function-auto-ready against this PR
• Using the v1.16 crossplane beta render command to send a v1beta1 RunFunctionRequest
• Using the crossplane render from Promote composition functions to v1, and deprecate patch and transform crossplane#5885 to send a v1 RunFunctionRequest

The function successfully served both, so I think this is good to go.

[negz]

This is the most interesting part of this PR. Everything else is just:

• Replicating the v1 and v1beta1 protos from Crossplane
• s/v1beta1/v1/ for all the imports of the protos

[jbw976]

The approach looks reasonable here to me, but I do have a couple questions about some parts of it work. Thank you @negz!

[jbw976]

can you remind me how this proto file content gets here to the SDK in the first place? is that automated, or is it a manual operation to duplicate it from crossplane/crossplane? do we have mechanisms in place to keep it in sync over time? 🤔

[negz]

It's just manual currently. It'd be nice to automate, but I'm not sure how to do that. Something like Renovate that noticed when it was updated in c/c and copied it over would be ideal.

[negz]

Tested again. Here's the output to make sure I didn't mix it up again:

This is a v1 request and response:

# $ ~/control/crossplane/crossplane/_output/bin/linux_arm64/crank render xr.yaml composition.yaml functions.yaml
---
apiVersion: example.crossplane.io/v1
kind: XR
metadata:
  name: example-xr
status:
  conditions:
  - lastTransitionTime: "2024-01-01T00:00:00Z"
    message: 'Unready resources: bucket'
    reason: Creating
    status: "False"
    type: Ready
---
apiVersion: s3.aws.upbound.io/v1beta1
kind: Bucket
metadata:
  annotations:
    crossplane.io/composition-resource-name: bucket
  generateName: example-xr-
  labels:
    crossplane.io/composite: example-xr
  ownerReferences:
  - apiVersion: example.crossplane.io/v1
    blockOwnerDeletion: true
    controller: true
    kind: XR
    name: example-xr
    uid: ""
spec:
  forProvider:
    region: us-east-2

This is a v1beta1 request and response, from the same function:

# $ ~/control/crossplane/crossplane/_output/bin/linux_arm64/crank beta render xr.yaml composition.yaml functions.yaml
---
apiVersion: example.crossplane.io/v1
kind: XR
metadata:
  name: example-xr
status:
  conditions:
  - lastTransitionTime: "2024-01-01T00:00:00Z"
    message: 'Unready resources: bucket'
    reason: Creating
    status: "False"
    type: Ready
---
apiVersion: s3.aws.upbound.io/v1beta1
kind: Bucket
metadata:
  annotations:
    crossplane.io/composition-resource-name: bucket
  generateName: example-xr-
  labels:
    crossplane.io/composite: example-xr
  ownerReferences:
  - apiVersion: example.crossplane.io/v1
    blockOwnerDeletion: true
    controller: true
    kind: XR
    name: example-xr
    uid: ""
spec:
  forProvider:
    region: us-east-2

[jbw976]

Nice, thanks for fixing the beta response issue and adding a test! now it all looks good to me! 😎