Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite EventStream #609

Closed
wants to merge 2 commits into from
Closed

Rewrite EventStream #609

wants to merge 2 commits into from

Conversation

Berrysoft
Copy link

@Berrysoft Berrysoft commented Oct 3, 2021 •
edited
Loading

Closes #608.

  • Add tokio & async-std reference.
  • Control them with features.
  • Check if the usage of polling is correct.
  • Use async-stream.

@Berrysoft Berrysoft changed the title Add tokio & async-std runtime support. Rewrite EventStream Oct 3, 2021
@Berrysoft
Copy link
Author

I've noticed that async-stream should simplify the implementation without adding tokio or async-std reference.

@Berrysoft
Copy link
Author

It seems that it is too naive as it will cause spins on CPU. I'm closing this pull request now, and will rethink my idea.

@Berrysoft Berrysoft closed this Oct 5, 2021
@BoolPurist BoolPurist mentioned this pull request Sep 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimonPost TimonPost Awaiting requested review from TimonPost TimonPost is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider using spawn and channel in specific async runtime.
1 participant
@Berrysoft