Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more Unit tests for the FileUtils class #653

Closed
andrii-bodnar opened this issue Oct 9, 2023 · 3 comments · Fixed by #660
Closed

Add more Unit tests for the FileUtils class #653

andrii-bodnar opened this issue Oct 9, 2023 · 3 comments · Fixed by #660
Assignees
@Sweetdevil144
Labels
good first issue hacktoberfest This issue welcomes contributions for Hacktoberfest tests

Comments

@andrii-bodnar
Copy link
Member

The FileUtils class has some methods that are not covered by Unit tests. We should add more Unit tests for this class.

References:
@andrii-bodnar andrii-bodnar added good first issue hacktoberfest This issue welcomes contributions for Hacktoberfest tests labels Oct 9, 2023
@Sweetdevil144
Copy link
Contributor

Sweetdevil144 commented Oct 9, 2023 •
edited
Loading

Hello @andrii-bodnar. Is the issue fixed yet?

If not, then I would like to work on it.

@andrii-bodnar
Copy link
Member Author

Hi @Sweetdevil144, it's still available, assigning it to you, thanks!

Sweetdevil144 added a commit to Sweetdevil144/crowdin-cli that referenced this issue Oct 11, 2023
@Sweetdevil144
Fix crowdin#653
76ce81c 
Added more Unit tests to FileUtils class
Improved code coverage from 70% to 95%
@Sweetdevil144 Sweetdevil144 mentioned this issue Oct 11, 2023
Merged
@Sweetdevil144
Copy link
Contributor

@andrii-bodnar Created a PR for the same !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sweetdevil144 Sweetdevil144

Labels
good first issue hacktoberfest This issue welcomes contributions for Hacktoberfest tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Adding missing tests to FileUtils class Sweetdevil144/crowdin-cli
2 participants
@andrii-bodnar @Sweetdevil144