Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] /build_test command enhancements #1634

Closed
andrewazores opened this issue Aug 24, 2023 · 3 comments · Fixed by #1683
Closed

[Task] /build_test command enhancements #1634

andrewazores opened this issue Aug 24, 2023 · 3 comments · Fixed by #1683
Assignees
Labels
feat New feature or request

Comments

@andrewazores
Copy link
Member

Describe the feature

Since https://github.com/cryostatio/cryostat/pull/1599 , reviewers can comment /build_test on PRs to trigger a CI run for integration tests and preview images. For example,

It would be nice if:

  • the bot could leave a comment of the Actions run when it starts
  • the bot could leave a comment noting whether the tests passed or failed
  • the workflow could be parallelized (again) - static analysis (shellcheck/spotbugs/spotless) can be done separately, with the unit testing and OCI packaging done separately from that with no dependency on static analysis, then integration testing and registry pushing can be done separately with only a dependency on the OCI packaging.
  • there could be a separate comment for retrying integration tests using the most recently-built images, ie /build_test first, then /retest to simply rerun the tests without a rebuild, if the reviewer suspects that the tests are simply flaky
  • is it possible for the /build_test to add a Status Check to the PR? Since moving these checks off from the pull_request_target and into a comment trigger, the checks do not seem to be linked anymore.

image

image

Anything other information?

No response

@andrewazores andrewazores added the feat New feature or request label Aug 24, 2023
@andrewazores
Copy link
Member Author

@mwangggg you're probably a bit sick of this work by now, but perhaps later on you can revisit it?

@andrewazores
Copy link
Member Author

andrewazores commented Sep 5, 2023

I think it would also be nice for the automatic CI run on every PR update (every push to the PR branch) to still trigger the headless compile and unit tests (ie. mvn -Dheadless clean test), just skip the image build/push and integration testing until manually triggered.

@andrewazores
Copy link
Member Author

Another potentially useful thing: https://github.com/marketplace/actions/slash-command-dispatch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants