Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): extract PR number for build_test command #1637

Merged
merged 1 commit into from
Aug 29, 2023
Merged

fix(ci): extract PR number for build_test command #1637

merged 1 commit into from
Aug 29, 2023

Conversation

mwangggg
Copy link
Member

@mwangggg mwangggg commented Aug 29, 2023 •
edited by andrewazores
Loading

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Fixes: #1584
Related: #1599 #1634

@mwangggg
Copy link
Member Author

demo: mwangggg#19 (comment)

@mwangggg mwangggg requested a review from tthvo August 29, 2023 15:28
tthvo
tthvo approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!!

@andrewazores andrewazores merged commit 8c6c6a1 into cryostatio:main Aug 29, 2023
12 checks passed
@mwangggg mwangggg deleted the build_test-fixup branch August 29, 2023 20:10
@tthvo tthvo mentioned this pull request Sep 8, 2023
Closed
andrewazores pushed a commit that referenced this pull request Sep 13, 2023
@mwangggg @andrewazores
fix(ci): extract PR number for build_test command (#1637)
9fb53a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tthvo tthvo tthvo approved these changes

@andrewazores andrewazores Awaiting requested review from andrewazores

Assignees
No one assigned
Labels
fix safe-to-test
Projects
No open projects
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Implement PR command /build_test
3 participants
@mwangggg @tthvo @andrewazores