-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(db): use h2:file db mode by default #1096
Conversation
5ea7928
to
5b5a39d
Compare
This PR/issue depends on:
|
5b5a39d
to
770ba8c
Compare
Along with setting the I also removed some There's more work to be done around the DAOs and how we use Hibernate/JPA in general to ensure we're handling data consistency properly and not leaving resources open, but that's outside the scope of this PR. |
0cc0cb0
to
b5b3a61
Compare
Is there any useful logs of these runs that I may be able to look at? |
I didn't bother preserving any of the ones I observed locally, but this CI run looks like it's the same thing: https://github.com/cryostatio/cryostat/actions/runs/3198632408/jobs/5223422453 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, that's weird - not too sure as of now without diving too deep, but anyways this PR looks good!
Sorry, I just went back and checked on the JPA entity detachment thing and found that the change was no longer making any difference. It may have just seemed that way by coincidence yesterday when I was testing it since it was only affecting the flaky test(s) to begin with. |
I also included a change to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes dev testing a lot faster, right looks good!
6130b15
to
6437126
Compare
Fixes #1094
Depends on #1083