Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(scripts): use xpath in cryostat dev scripts if available #1356

Merged
merged 4 commits into from
Feb 2, 2023
Merged

chore(scripts): use xpath in cryostat dev scripts if available #1356

merged 4 commits into from
Feb 2, 2023

Conversation

maxcao13
Copy link
Member

@maxcao13 maxcao13 commented Feb 2, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Fixes: #1355

Description of the change:

This allows cryostat dev setup to be faster with xpath if it is available vs. using mvn:evaluate.

How to manually test:

  1. Have optional xpath installed
  2. Run sh smoketest.sh with this pr changes, and without and see the difference.

@maxcao13 maxcao13 added the chore Refactor, rename, cleanup, etc. label Feb 2, 2023
@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Feb 2, 2023
@mergify mergify bot added the safe-to-test label Feb 2, 2023
@maxcao13 maxcao13 removed the needs-triage Needs thorough attention from code reviewers label Feb 2, 2023
tthvo
tthvo reviewed Feb 2, 2023
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Maybe also this script repeated-integration-tests.bash?

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1356-e24ea169ff76e1da035d098c1361d3a589de3e35 sh smoketest.sh

@maxcao13
revert test typo
85d74a4 
Signed-off-by: Max Cao <macao@redhat.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1356-85d74a4bd15255fbb6fb39642016e94a430573b0 sh smoketest.sh

tthvo
tthvo approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice work!

@andrewazores andrewazores merged commit 81aef2d into cryostatio:main Feb 2, 2023
@maxcao13 maxcao13 deleted the xpath-if-installed branch February 2, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

@tthvo tthvo tthvo approved these changes

Assignees
No one assigned
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
No open projects
2.3.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Use xpath if it is available in cryostat scripts
3 participants
@maxcao13 @andrewazores @tthvo