Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vertx): configurable worker pool size #1468

Merged
merged 3 commits into from
Apr 25, 2023
Merged

feat(vertx): configurable worker pool size #1468

merged 3 commits into from
Apr 25, 2023

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Apr 22, 2023 •
edited
Loading

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Related to #1448
Related to #1467

@mergify mergify bot added the safe-to-test label Apr 22, 2023
@andrewazores andrewazores marked this pull request as ready for review April 22, 2023 15:32
@andrewazores andrewazores added the feat New feature or request label Apr 22, 2023
@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1468-f1981cc1b05de0b05e73b3e7bf8bea2e558c1920 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1468-763b3d1cff3353e726f5c76fa51ed9d66713d321 sh smoketest.sh

maxcao13
maxcao13 reviewed Apr 25, 2023
View reviewed changes
Copy link
Member

@maxcao13 maxcao13 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for testing, run.sh should have an -e argument to pass the variable?

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1468-40fd7f23bfa068d1f396fd82dc760cb24103e431 sh smoketest.sh

@andrewazores andrewazores merged commit c212221 into cryostatio:main Apr 25, 2023
@andrewazores andrewazores deleted the vertx-worker-pool-size branch April 25, 2023 18:09
mergify bot pushed a commit that referenced this pull request Apr 25, 2023
@andrewazores @mergify
feat(vertx): configurable worker pool size (#1468)
f473a9f 
(cherry picked from commit c212221)
@mergify mergify bot mentioned this pull request Apr 25, 2023
Merged
andrewazores added a commit that referenced this pull request Apr 25, 2023
@mergify @andrewazores
feat(vertx): configurable worker pool size (#1468) (#1472)
2293d32 
(cherry picked from commit c212221)

Co-authored-by: Andrew Azores <aazores@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcao13 maxcao13 maxcao13 approved these changes

Assignees
No one assigned
Labels
backport feat New feature or request safe-to-test
Projects
No open projects
2.3.0 release
Status: Done
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewazores @maxcao13