Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin): send additional env payload to plugins on registration #1520

Merged
merged 9 commits into from
Nov 9, 2023
Merged

feat(plugin): send additional env payload to plugins on registration #1520

merged 9 commits into from
Nov 9, 2023

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Jun 6, 2023 •
edited
Loading

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Related to cryostatio/cryostat-operator#596
Related to https://github.com/cryostatio/cryostat/issues/1763

Description of the change:

This change adds allows a match expression example to be copied to the clipboard...

Motivation for the change:

This change is helpful because users may want to copy the example for easier use...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Jun 6, 2023
@mergify mergify bot added the safe-to-test label Jun 6, 2023
@andrewazores andrewazores added feat New feature or request and removed needs-triage Needs thorough attention from code reviewers labels Jun 6, 2023
@andrewazores andrewazores mentioned this pull request Jun 6, 2023
Merged
@andrewazores andrewazores changed the title feat(plugin): send additional platform env extras to plugins on registration" feat(plugin): send additional platform env extras to plugins on registration Jun 7, 2023
mergify[bot]
mergify bot requested changes Jun 7, 2023
View reviewed changes
Copy link

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request blocked. web-client submodule updates are performed automatically by CI when that repository is updated. Please revert or drop all changes to the web-client submodule from this PR and perform any required frontend work by opening and merging a PR against cryostat-web.

mergify[bot]
mergify bot previously requested changes Jun 7, 2023
View reviewed changes
Copy link

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request blocked. web-client submodule updates are performed automatically by CI when that repository is updated. Please revert or drop all changes to the web-client submodule from this PR and perform any required frontend work by opening and merging a PR against cryostat-web.

@andrewazores andrewazores force-pushed the platform-env-map branch 2 times, most recently from fe96368 to 92683f6 Compare June 12, 2023 14:57
@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1520-27299ddd455f1bf1b01ffb15f24b7a42156cc7da sh smoketest.sh

@andrewazores andrewazores marked this pull request as ready for review November 9, 2023 15:39
@andrewazores
Copy link
Member Author

/build_test

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

Workflow started at 11/9/2023, 10:40:33 AM. View Actions Run.

@andrewazores andrewazores mentioned this pull request Nov 9, 2023
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat:pr-1520-d5634b2f1dd02596ece5ce208a5ca3f38cedbf4e-linux-amd64
arm64 ghcr.io/cryostatio/cryostat:pr-1520-d5634b2f1dd02596ece5ce208a5ca3f38cedbf4e-linux-arm64

To run smoketest:

# amd64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1520-d5634b2f1dd02596ece5ce208a5ca3f38cedbf4e-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1520-d5634b2f1dd02596ece5ce208a5ca3f38cedbf4e-linux-arm64 sh smoketest.sh

@andrewazores andrewazores changed the title feat(plugin): send additional platform env extras to plugins on registration feat(plugin): send additional env payload to plugins on registration Nov 9, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

/build_test completed successfully ✅.
View Actions Run.

@andrewazores andrewazores merged commit 5cfd2fc into cryostatio:main Nov 9, 2023
8 checks passed
@andrewazores andrewazores deleted the platform-env-map branch November 9, 2023 16:27
mergify bot pushed a commit that referenced this pull request Nov 9, 2023
@andrewazores @mergify
feat(plugin): send additional env payload to plugins on registration (#…
06d01c5 
…1520)

(cherry picked from commit 5cfd2fc)
@mergify mergify bot mentioned this pull request Nov 9, 2023
Merged
andrewazores added a commit that referenced this pull request Nov 9, 2023
@mergify @andrewazores
feat(plugin): send additional env payload to plugins on registration (#…
f5a1220 
…1520) (#1773)

(cherry picked from commit 5cfd2fc)

Co-authored-by: Andrew Azores <aazores@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebaron ebaron ebaron approved these changes

@mergify Mergify mergify left review comments

Assignees
No one assigned
Labels
backport feat New feature or request safe-to-test
Projects
No open projects
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewazores @ebaron