Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pom): upgrade vert-x from 4.4.4 to 4.4.9 #1913

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Description of the change:

This change allows an environment variable to be configured so that...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

@andrewazores andrewazores requested a review from a team as a code owner April 22, 2024 21:25
Copy link
Contributor

Hi @andrewazores! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test

Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Apr 22, 2024
@andrewazores andrewazores added backport dependencies Pull requests that update a dependency file chore Refactor, rename, cleanup, etc. safe-to-test and removed needs-triage Needs thorough attention from code reviewers labels Apr 22, 2024
@andrewazores
Copy link
Member Author

/build_test

Copy link
Contributor

Workflow started at 4/22/2024, 5:26:07 PM. View Actions Run.

Copy link
Contributor

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat:pr-1913-3d78705fa85b5d8376d267dfcf2efff8a87d35f6-linux-amd64
arm64 ghcr.io/cryostatio/cryostat:pr-1913-3d78705fa85b5d8376d267dfcf2efff8a87d35f6-linux-arm64

To run smoketest:

# amd64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1913-3d78705fa85b5d8376d267dfcf2efff8a87d35f6-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1913-3d78705fa85b5d8376d267dfcf2efff8a87d35f6-linux-arm64 sh smoketest.sh

Copy link
Contributor

/build_test : At least one test failed ❌.
View Actions Run.

@andrewazores
Copy link
Member Author

/retest

Copy link
Contributor

Workflow started at 4/22/2024, 5:41:22 PM. View Actions Run.

Copy link
Contributor

/retest Integration: At least one test failed ❌.
View Actions Run.

Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@andrewazores
Copy link
Member Author

/build_test

Copy link
Contributor

Workflow started at 4/22/2024, 6:06:04 PM. View Actions Run.

Copy link
Contributor

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat:pr-1913-f5c1df23b95029cf21186a9ae1a0de159b6d8255-linux-amd64
arm64 ghcr.io/cryostatio/cryostat:pr-1913-f5c1df23b95029cf21186a9ae1a0de159b6d8255-linux-arm64

To run smoketest:

# amd64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1913-f5c1df23b95029cf21186a9ae1a0de159b6d8255-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1913-f5c1df23b95029cf21186a9ae1a0de159b6d8255-linux-arm64 sh smoketest.sh

Copy link
Contributor

/build_test completed successfully ✅.
View Actions Run.

@ebaron ebaron merged commit b2e0c30 into cryostatio:main Apr 22, 2024
7 of 8 checks passed
@andrewazores andrewazores deleted the vertx-upgrade branch April 22, 2024 22:27
mergify bot pushed a commit that referenced this pull request Apr 22, 2024
* chore(pom): upgrade vertx from 4.4.4 to 4.4.9

* fix test mockito specifications for new overload

* upgrade netty

(cherry picked from commit b2e0c30)
ebaron pushed a commit that referenced this pull request Apr 22, 2024
* chore(pom): upgrade vertx from 4.4.4 to 4.4.9

* fix test mockito specifications for new overload

* upgrade netty
ebaron pushed a commit that referenced this pull request Apr 22, 2024
* chore(pom): upgrade vertx from 4.4.4 to 4.4.9

* fix test mockito specifications for new overload

* upgrade netty

(cherry picked from commit b2e0c30)

Co-authored-by: Andrew Azores <aazores@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport chore Refactor, rename, cleanup, etc. dependencies Pull requests that update a dependency file safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants