fix(templates): templates should be mounted if TLS disabled #262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a case of nesting this code in a branch it shouldn't be in. I added a test case to ensure this works when TLS is disabled as well.
To test manually:
make deploy IMG=<test_img> create_cryostat_cr
kubectl create configmap my-template --from-file=custom.jfc
kubectl edit cryostat cryostat-sample
, changespec.enableCertManager
to false and add the template tospec.eventTemplates
[1]Fixes #240
[1] https://github.com/cryostatio/cryostat-operator/blob/main/docs/config.md#custom-event-templates