Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openshift): force platform/auth on OpenShift #274

Merged
merged 1 commit into from
Oct 2, 2021

Conversation

ebaron
Copy link
Member

@ebaron ebaron commented Oct 1, 2021

This PR adds the CRYOSTAT_PLATFORM and CRYOSTAT_AUTH_MANAGER environment variables when running on OpenShift. This also changes the OpenShift detection mechanism to not use the caching client to hopefully avoid situations like #210, but I have not encountered it again since filing.

Fixes #273, #210

@ebaron ebaron linked an issue Oct 1, 2021 that may be closed by this pull request
@ebaron ebaron merged commit 36fff35 into cryostatio:main Oct 2, 2021
mergify bot pushed a commit that referenced this pull request Oct 2, 2021
ebaron added a commit that referenced this pull request Oct 5, 2021
(cherry picked from commit 36fff35)

Co-authored-by: Elliott Baron <ebaron@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication bypass if API server unreachable OpenShift detection does not always work
2 participants