Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth): Encode auth bearer token #291

Merged
merged 3 commits into from
Nov 3, 2021
Merged

fix(auth): Encode auth bearer token #291

merged 3 commits into from
Nov 3, 2021

Conversation

jan-law
Copy link
Contributor

@jan-law jan-law commented Nov 3, 2021

Fixes #290

@jan-law jan-law added the fix label Nov 3, 2021
@jan-law jan-law requested a review from ebaron November 3, 2021 18:14
ebaron
ebaron approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@ebaron ebaron merged commit 1708d3c into cryostatio:main Nov 3, 2021
@jan-law jan-law deleted the encode-bearer-token branch November 3, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebaron ebaron ebaron approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auth token should be Base64 encoded
2 participants
@jan-law @ebaron