Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(makefile): Rename the IMG env var to OPERATOR_IMG #386

Merged
merged 2 commits into from
May 5, 2022

Conversation

divyakelaskar
Copy link
Contributor

@divyakelaskar divyakelaskar commented May 5, 2022

Fixes #385

@andrewazores andrewazores changed the title refactor : Rename the IMG env var to OPERATOR_IMG refactor(makefile): Rename the IMG env var to OPERATOR_IMG May 5, 2022
@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. build labels May 5, 2022
Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! There are other places within the Makefile that reference that IMG variable by name, for example on line 121. All of those will need to be updated as well to match the updated name.

Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @ebaron ?

Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution @divyakelaskar!

@ebaron ebaron requested a review from andrewazores May 5, 2022 21:14
@ebaron ebaron added the refactor label May 5, 2022
@ebaron ebaron merged commit 4092d9e into cryostatio:main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build chore Refactor, rename, cleanup, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename IMG env var to OPERATOR_IMG
3 participants