Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openshift): update existing console links #467

Merged
merged 4 commits into from
Oct 11, 2022

Conversation

ebaron
Copy link
Member

@ebaron ebaron commented Oct 6, 2022

This is a fairly straightforward refactoring of the console links and API server config modification into a new openshift.go file. The new feature here is just a small change to update console link specs after they have been created.

Fixes: #414

@ebaron ebaron added the feat New feature or request label Oct 6, 2022
@ebaron ebaron marked this pull request as ready for review October 11, 2022 15:53
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple of questions :D

Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me :D

@ebaron ebaron merged commit 77cd521 into cryostatio:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Existing ConsoleLinks should be updated
2 participants