-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(openshift): update existing console links #467
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebaron
force-pushed
the
update-consolelinks
branch
from
October 7, 2022 22:12
17c39a6
to
a3c6bfa
Compare
ebaron
force-pushed
the
update-consolelinks
branch
from
October 11, 2022 15:50
a3c6bfa
to
f62a772
Compare
ebaron
commented
Oct 11, 2022
tthvo
reviewed
Oct 11, 2022
tthvo
reviewed
Oct 11, 2022
tthvo
reviewed
Oct 11, 2022
tthvo
reviewed
Oct 11, 2022
tthvo
reviewed
Oct 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a couple of questions :D
ebaron
force-pushed
the
update-consolelinks
branch
from
October 11, 2022 18:57
f024fd1
to
1f0ce8a
Compare
ebaron
force-pushed
the
update-consolelinks
branch
from
October 11, 2022 19:04
5c3f9b6
to
0cfe38e
Compare
tthvo
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly straightforward refactoring of the console links and API server config modification into a new
openshift.go
file. The new feature here is just a small change to update console link specs after they have been created.Fixes: #414