test(reconcile): simulate controllers with custom client #510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the logic for updating certificate and route statuses from
reconcileCryostatFully
to a custom client implementation. This client triggers the update upon the first successfulGet
call. This happens after the object has been created, so we're still exercising theRequeueAfter
code paths.The advantage here is that we can simplify how we do reconciles in the tests themselves. I've changed
reconcileCryostatFully
to use Gomega'sEventually
to callReconcile
asynchronously until it no longer re-queues or times out. This allows us to usereconcileCryostatFully
in more places.I also removed an unnecessary
Get
call for the certificate incommon/tls.go
. We already have the certificate in memory, and this was triggering the certificate update logic earlier than desired.Fixes: #509