Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): capitalize JMX credentials DB display name #518

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Feb 1, 2023

This manually specifies the displayName for JmxCredentialsDatabaseOptions option. I have built a bundle image for checking these changes here:

quay.io/thvo/cryostat-operator-bundle:2.3.0-pr517

Screenshot from 2023-02-01 02-09-58

Fixes #516

@tthvo tthvo added the fix label Feb 1, 2023
@tthvo tthvo requested a review from ebaron February 1, 2023 07:12
@tthvo tthvo changed the title fix(api): capitalize JMX credentials DB display name chore(api): capitalize JMX credentials DB display name Feb 1, 2023
@tthvo tthvo added chore Refactor, rename, cleanup, etc. and removed fix labels Feb 1, 2023
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @tthvo!

@ebaron ebaron merged commit 8aa0123 into cryostatio:main Feb 2, 2023
@tthvo tthvo deleted the jmx-db-displayname branch February 2, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Fix capitalization for JMX Credentials DB display name
2 participants