Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sample): add quarkus-test-agent sample app #578

Merged
merged 11 commits into from
May 10, 2023
Merged

feat(sample): add quarkus-test-agent sample app #578

merged 11 commits into from
May 10, 2023

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #577

@andrewazores andrewazores requested review from ebaron and tthvo May 4, 2023 15:06
@andrewazores andrewazores added the chore Refactor, rename, cleanup, etc. label May 4, 2023
tthvo
tthvo reviewed May 4, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
tthvo
tthvo reviewed May 9, 2023
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just seeing if @ebaron has any comments.

@andrewazores andrewazores merged commit b22cc8b into cryostatio:main May 10, 2023
@andrewazores andrewazores deleted the agent-sample branch May 10, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebaron ebaron ebaron approved these changes

@tthvo tthvo tthvo approved these changes

Assignees
No one assigned
Labels
chore Refactor, rename, cleanup, etc.
Projects
No open projects
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request] Sample app using Cryostat Agent
3 participants
@andrewazores @ebaron @tthvo