-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): clean up test images after closing PRs #609
feat(ci): clean up test images after closing PRs #609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Once we address the new comments, can you provide a sample run?
891f073
to
018a796
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it makes sense. Any sample run?
Yes, we had a meeting at 1pm, me and @tthvo. He showed me how I can run and make a PR on my fork. Made a few runs that failed and then it passed. I closed the PRs, see if I can retrieve them and the results. |
There is a newer release of that action: https://github.com/r26D/ghcr-delete-image-action . There is also this other action that might work instead: https://github.com/bots-house/ghcr-delete-image-action |
Looks good like it did update node env :)) https://github.com/r26D/ghcr-delete-image-action/releases/tag/v1.3.0 |
@aali309 great work, thanks for doing it! |
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit -S -m "YOUR_COMMIT_MESSAGE"
Fixes: #603
Description of the change:
This change allows the removal of test images after the PR is closed
Motivation for the change:
This change is helpful because it helps get rid of polluted dangling images
How to manually test: