Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): clean up test images after closing PRs #609

Merged

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented Aug 23, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #603

Description of the change:

This change allows the removal of test images after the PR is closed

Motivation for the change:

This change is helpful because it helps get rid of polluted dangling images

How to manually test:

  1. Insert steps here...
  2. ...

@aali309 aali309 self-assigned this Aug 23, 2023
@aali309 aali309 added feat New feature or request safe-to-test labels Aug 23, 2023
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Once we address the new comments, can you provide a sample run?

@aali309 aali309 force-pushed the Preview/TestShouldBeCleanedAfterPRclosed branch from 891f073 to 018a796 Compare August 25, 2023 18:33
@aali309 aali309 changed the title feat(ci): preview/Test images should be cleaned up after closing PRs feat(ci): clean up test images after closing PRs Aug 25, 2023
@tthvo tthvo added the ci label Aug 25, 2023
@aali309 aali309 marked this pull request as ready for review August 25, 2023 18:55
Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it makes sense. Any sample run?

@aali309
Copy link
Contributor Author

aali309 commented Aug 25, 2023

Looks like it makes sense. Any sample run?

Yes, we had a meeting at 1pm, me and @tthvo. He showed me how I can run and make a PR on my fork. Made a few runs that failed and then it passed. I closed the PRs, see if I can retrieve them and the results.

@andrewazores
Copy link
Member

image

r26d/ghcr-delete-image-action@v1.2.2

There is a newer release of that action: https://github.com/r26D/ghcr-delete-image-action . 1.3.0 looks like the latest, though I don't know if it clears up this deprecation warning.

There is also this other action that might work instead: https://github.com/bots-house/ghcr-delete-image-action

@tthvo
Copy link
Member

tthvo commented Aug 28, 2023

There is a newer release of that action: https://github.com/r26D/ghcr-delete-image-action . 1.3.0 looks like the latest, though I don't know if it clears up this deprecation warning.

Looks good like it did update node env :)) https://github.com/r26D/ghcr-delete-image-action/releases/tag/v1.3.0

@andrewazores andrewazores merged commit f7abf5a into cryostatio:main Aug 28, 2023
11 checks passed
@ebaron
Copy link
Member

ebaron commented Aug 28, 2023

@aali309 great work, thanks for doing it!

@tthvo tthvo mentioned this pull request Aug 28, 2023
7 tasks
@aali309 aali309 deleted the Preview/TestShouldBeCleanedAfterPRclosed branch August 28, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci feat New feature or request safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Request] Preview/Test images should be cleaned up after closing PRs
4 participants