Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): replaced GHCR_PR_TOKEN with GITHUB_TOKEN #635

Merged
merged 3 commits into from
Oct 3, 2023
Merged

feat(ci): replaced GHCR_PR_TOKEN with GITHUB_TOKEN #635

merged 3 commits into from
Oct 3, 2023

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented Sep 28, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #613

Description of the change:

Replace GHCR_PR_TOKEN with GITHUB_TOKEN

Motivation for the change:

Raised initially by Thuan

How to manually test:

  1. Insert steps here...
  2. ...

@aali309 aali309 added feat New feature or request and removed ci labels Sep 28, 2023
@aali309 aali309 changed the title feat(ci):replaced GHCR_PR_TOKEN with GITHUB_TOKEN feat(ci): replaced GHCR_PR_TOKEN with GITHUB_TOKEN Sep 28, 2023
andrewazores
andrewazores reviewed Sep 28, 2023
View reviewed changes
Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any sample run to verify that no additional permissions need to be specified/granted to this token?

@tthvo
Copy link
Member

tthvo commented Sep 28, 2023

We will also need to grant cryostat-operator repo access (i.e. write) to the -operator, -operator-scorecard and -operator-bundle "packages" on ghcr.io.

@aali309
Copy link
Contributor Author

aali309 commented Sep 29, 2023 •
edited
Loading

https://github.com/aali309/cryostat-operator/actions/runs/6351069848

image

@andrewazores
Copy link
Member

We will also need to grant cryostat-operator repo access (i.e. write) to the -operator, -operator-scorecard and -operator-bundle "packages" on ghcr.io.

Nice, I think I have set that up properly now.

@aali309 aali309 force-pushed the ReplaceGHCR_PR_TOKENwithGITHUB_TOKEN branch from 8e619bb to 183174b Compare September 29, 2023 14:53
@tthvo tthvo requested a review from ebaron September 29, 2023 18:23
ebaron
ebaron approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @aali309!

@ebaron ebaron merged commit bbe5d48 into cryostatio:main Oct 3, 2023
6 checks passed
@aali309 aali309 mentioned this pull request Oct 3, 2023
Merged
7 tasks
@aali309 aali309 deleted the ReplaceGHCR_PR_TOKENwithGITHUB_TOKEN branch October 4, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores left review comments

@tthvo tthvo tthvo left review comments

@ebaron ebaron ebaron approved these changes

@mwangggg mwangggg Awaiting requested review from mwangggg

Assignees
No one assigned
Labels
feat New feature or request safe-to-test
Projects
No open projects
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request] Replace GHCR_PR_TOKEN with GITHUB_TOKEN
4 participants
@aali309 @tthvo @andrewazores @ebaron