-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): add short summaries to targets #636
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! Just a few minor suggestions to rephrase some of the descriptions, but overall this is great.
I guess that should be everything? Thanks for the reviews ^^ |
Guess not lol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Any other comments @andrewazores @ebaron?
Uhh... what. I guess that's a failure in my rebase attempt. |
@pektezol just force-push from your local |
Or at worst, the Makefile patch in the force-push comparison is still there and contains basically the reverse patch needed: |
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit -S -m "YOUR_COMMIT_MESSAGE"
Fixes: #634
Description of the change:
This change will make it easier for people to see Makefile targets clearly, with topic handles and short summaries using
make help
. Let me know if it needs readjusting in any way.Motivation for the change:
To contribute to an open-source project.
How to manually test:
make help