Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(scorecard): scorecard tests for recording management (backport #698) #752

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 6, 2024

This is an automatic backport of pull request #698 done by Mergify.
Cherry-pick of cfcbfc7 has failed:

On branch mergify/bp/cryostat3/pr-698
Your branch is up to date with 'origin/cryostat3'.

You are currently cherry-picking commit cfcbfc7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/test-ci-reusable.yml
	modified:   bundle/tests/scorecard/config.yaml
	modified:   config/rbac/oauth_client.yaml
	modified:   config/scorecard/bases/config.yaml
	modified:   config/scorecard/patches/custom.config.yaml
	modified:   hack/custom.config.yaml.in
	modified:   internal/images/custom-scorecard-tests/main.go
	modified:   internal/images/custom-scorecard-tests/rbac/scorecard_role.yaml
	modified:   internal/test/scorecard/clients.go
	new file:   internal/test/scorecard/common_utils.go
	modified:   internal/test/scorecard/openshift.go
	modified:   internal/test/scorecard/tests.go
	new file:   internal/test/scorecard/types.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   bundle/manifests/cryostat-operator.clusterserviceversion.yaml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* test(scorecard): scorecard tests for recording management

Signed-off-by: Thuan Vo <thuan.votann@gmail.com>

* fixup(scorecard): fix cr cleanup func

* test(scorecard): registry recording test to suite

* chore(scorecard): reorganize client def

* chore(scorecard): clean up common setup func

* chore(bundle): regenerate bundle with scorecard tag

* chore(bundle): correct image tag in bundle

* fix(bundle): add missing scorecard test config patch

* feat(scorecard): scaffold cryostat API client

* chore(scorecard): clean up API client

* test(scorecard): implement recording scorecard test

* fixup(scorecard): correctly add scorecard test via hack templates

* fix(client): ignore unverified tls certs and base64 oauth token

* chore(bundle): split cryostat tests to separate stage

* fix(scorecard): extend default transport instead of overwriting

* chore(scorecard): refactor client to support multi-part

* fixup(client): fix request verb

* fix(client): fix recording create form format

* fix(scorecard): create stored credentials for target JVM

* fix(scorecard): fix 502 status error

* chore(scorecard): simplify client def

* chore(scorecard): fetch recordings to ensure action is correctly performed

* test(scorecard): test generating report for a recording

* chore(scorecard): clean up

* test(scorecard): list archives in tests

* ci(scorecard): reconfigure ingress for kind

* ci(k8s): correct cluster name

* test(scorecard): use role instead of clusterrole for oauth rules

* test(scorecard): parse health response for additional checks

* chore(scorecard): add missing newline in logs

* chore(scorecard): check status code before parsing body in health check

* test(scorecard): add custom target discovery to recording scorecard test

* add EOF wait and resp headers

* add resp headers

* chore(client): configure all clients to send safe requests

* fix(clients): add missing content-type header

* fix(scorecard): add missing test name in help message

* chore(client): create new http requests when retrying

* chore(bundle): update scorecard image tags

---------

Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
Co-authored-by: Ming Yu Wang <90855268+mwangggg@users.noreply.github.com>
Co-authored-by: Ming Wang <miwan@redhat.com>
(cherry picked from commit cfcbfc7)

# Conflicts:
#	bundle/manifests/cryostat-operator.clusterserviceversion.yaml
@mergify mergify bot added the conflicts label Mar 6, 2024
Copy link
Contributor Author

mergify bot commented Mar 6, 2024

Cherry-pick of cfcbfc7 has failed:

On branch mergify/bp/cryostat3/pr-698
Your branch is up to date with 'origin/cryostat3'.

You are currently cherry-picking commit cfcbfc7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/test-ci-reusable.yml
	modified:   bundle/tests/scorecard/config.yaml
	modified:   config/rbac/oauth_client.yaml
	modified:   config/scorecard/bases/config.yaml
	modified:   config/scorecard/patches/custom.config.yaml
	modified:   hack/custom.config.yaml.in
	modified:   internal/images/custom-scorecard-tests/main.go
	modified:   internal/images/custom-scorecard-tests/rbac/scorecard_role.yaml
	modified:   internal/test/scorecard/clients.go
	new file:   internal/test/scorecard/common_utils.go
	modified:   internal/test/scorecard/openshift.go
	modified:   internal/test/scorecard/tests.go
	new file:   internal/test/scorecard/types.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   bundle/manifests/cryostat-operator.clusterserviceversion.yaml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@ebaron
Copy link
Member

ebaron commented Mar 6, 2024

/build_test

Copy link

github-actions bot commented Mar 6, 2024

/build_test completed successfully ✅.
View Actions Run.

@ebaron ebaron merged commit fcf7a8c into cryostat3 Mar 6, 2024
7 checks passed
@ebaron ebaron added test and removed conflicts labels Mar 6, 2024
@mergify mergify bot deleted the mergify/bp/cryostat3/pr-698 branch March 6, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants