Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(scorecard): fix broken scorecard tests for 3.0 #820

Merged
merged 1 commit into from
May 13, 2024

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented May 11, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #816

Description of the change:

Motivation for the change:

See #816

How to manually test:

export PLATFORMS=linux/amd64
export IMAGE_NAMESPACE=quay.io/<namespace>
make scorecard-build bundle bundle-build && podman push quay.io/<namespace>/cryostat-operator-bundle:2.5.0-dev && make test-scorecard

@tthvo
Copy link
Member Author

tthvo commented May 11, 2024

/build_test

@tthvo tthvo requested a review from a team May 11, 2024 06:54
Copy link

/build_test completed successfully ✅.
View Actions Run.

Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tthvo , great work!

@andrewazores andrewazores merged commit 95fa911 into cryostatio:cryostat3 May 13, 2024
7 checks passed
@tthvo tthvo deleted the scorecard-fix branch May 13, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants