Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump controller-tools version to 0.14.0 #851

Merged
merged 1 commit into from
Jun 6, 2024
Merged

build(deps): bump controller-tools version to 0.14.0 #851

merged 1 commit into from
Jun 6, 2024

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Jun 6, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Related to #849

Description of the change:

  • Bumped controller-tools to 0.14.0 to be compatible with Go 1.22+

@tthvo
build(deps): bump controller-tools version to 0.14.0
df2c135 
Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
@tthvo tthvo requested review from andrewazores and ebaron June 6, 2024 18:28
@tthvo
Copy link
Member Author

tthvo commented Jun 6, 2024

/build_test

andrewazores
andrewazores approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tthvo , I was just about to do this myself.

@andrewazores
Copy link
Member

/build_test

https://github.com/cryostatio/cryostat-operator/actions/runs/9406013939

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

/build_test completed successfully ✅.
View Actions Run.

@andrewazores andrewazores merged commit 1be75e9 into cryostatio:cryostat3 Jun 6, 2024
7 checks passed
@tthvo tthvo deleted the controller-tools-v branch June 6, 2024 18:48
@andrewazores andrewazores mentioned this pull request Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

@ebaron ebaron Awaiting requested review from ebaron

Assignees
No one assigned
Labels
build safe-to-test
Projects
No open projects
3.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tthvo @andrewazores