Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webhook): make label selectors unambiguous #926

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

ebaron
Copy link
Member

@ebaron ebaron commented Jul 30, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #924

Description of the change:

  • Adds app.kubernetes.io/name label to all operator objects using commonLabels Kustomize property
  • Cleanup: uncomments patch to remove cert volume and mount from bundle manifests, which is unneeded when run as a bundle

Motivation for the change:

  • Fixes a bug where webhook requests may be sent to other operators in the same namespace

How to manually test:

  1. Install another operator with a webhook (e.g. Infinispan Operator)
  2. Deploy this PR into the same namespace
  3. Exercise webhooks by creating and modifying Cryostat CRs

@ebaron ebaron requested a review from a team July 30, 2024 21:06
@mergify mergify bot added the safe-to-test label Jul 30, 2024
@ebaron
Copy link
Member Author

ebaron commented Jul 30, 2024

/build_test

Copy link

/build_test completed successfully ✅.
View Actions Run.

@ebaron ebaron merged commit 25de979 into cryostatio:main Jul 31, 2024
7 checks passed
mergify bot pushed a commit that referenced this pull request Jul 31, 2024
(cherry picked from commit 25de979)

# Conflicts:
#	bundle/manifests/cryostat-operator.clusterserviceversion.yaml
ebaron added a commit that referenced this pull request Jul 31, 2024
* fix(webhook): make label selectors unambiguous (#926)

(cherry picked from commit 25de979)

# Conflicts:
#	bundle/manifests/cryostat-operator.clusterserviceversion.yaml

* Fix conflicts

---------

Co-authored-by: Elliott Baron <ebaron@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] failed calling webhook "vcryostat.kb.io" due to TLS error
2 participants