feat(auth): Add OAuth logout #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-law
commented
Dec 21, 2021
jan-law
force-pushed
the
oauth-logout
branch
from
7828ac1
to
734984f
Compare
jan-law
commented
Dec 21, 2021
added 8 commits
January 17, 2022 11:49
|
If I log in to my CRC
The error messages appearing due to the failed requests (stemming from permissions denied) are expected. But, I don't have a user menu here and no obvious way to log out from this under-permissioned account. |
|
I've added an empty state component that will only appear when an account doesn't have the required permissions. "Retry Login" should take you to the OpenShift Container Platform login page. |
andrewazores
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related https://github.com/cryostatio/cryostat/issues/717
In order to log out of the OAuth server, the frontend needs to make a POST request to the OAuth server's
/logoutendpoint, which removes the session cookie stored in the OAuth server. The backend will delete the access token and return the/logouturl. Note that deleting the access token without removing the session cookie will cause the OAuth server to immediately login a user after logging out.OpenShift OAuth logout docs
OpenShift OAuth endpoint for deleting access tokens
OpenShift console UI code explaining logout behaviour