Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): workflows added #112

Merged
merged 7 commits into from
Oct 19, 2023
Merged

feat(ci): workflows added #112

merged 7 commits into from
Oct 19, 2023

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented Oct 17, 2023 •
edited
Loading

Based on: #22

Added similar workflows set of CI configurations as the previous cryostat project.

@aali309 aali309 added ci feat New feature or request safe-to-test labels Oct 17, 2023
@aali309 aali309 closed this Oct 17, 2023
@aali309 aali309 reopened this Oct 17, 2023
andrewazores
andrewazores reviewed Oct 17, 2023
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
@aali309
Copy link
Contributor Author

aali309 commented Oct 17, 2023 •
edited
Loading

Sample run:
image

link: https://github.com/aali309/cryostat3/actions

andrewazores
andrewazores reviewed Oct 18, 2023
View reviewed changes
.mergify.yml Outdated Show resolved Hide resolved
andrewazores
andrewazores reviewed Oct 18, 2023
View reviewed changes
.mergify.yml Outdated Show resolved Hide resolved
@mwangggg
Copy link
Member

should add a CONTRIBUTING.md file?

@aali309 aali309 self-assigned this Oct 18, 2023
andrewazores
andrewazores reviewed Oct 19, 2023
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
@andrewazores
Copy link
Member

Looking good, just needs a couple of images replaced I think once you've sorted out the re-forking thing.

@aali309
Copy link
Contributor Author

aali309 commented Oct 19, 2023

Looking good, just needs a couple of images replaced I think once you've sorted out the re-forking thing.

I think this will need to be merged for me to re-fork because I will have to delete the current fork. After re-forking, I can open a new PR referencing this one to add the two missing images.

@andrewazores
Copy link
Member

Sure, that works too. Did you have any other PRs in progress when the repo visibility changed or was it just this one?

@aali309
Copy link
Contributor Author

aali309 commented Oct 19, 2023

Sure, that works too. Did you have any other PRs in progress when the repo visibility changed or was it just this one?

No just this one. All others were to test with my local main.

@andrewazores andrewazores merged commit ce739b6 into main Oct 19, 2023
6 of 7 checks passed
@andrewazores andrewazores mentioned this pull request Oct 19, 2023
Closed
@aali309 aali309 mentioned this pull request Oct 20, 2023
Merged
7 tasks
@aali309 aali309 deleted the setCIconfigAsPreviousCrysostat branch May 30, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tthvo tthvo tthvo left review comments

@mwangggg mwangggg mwangggg left review comments

@andrewazores andrewazores andrewazores approved these changes

Assignees

@aali309 aali309

Labels
ci feat New feature or request safe-to-test
Projects
No open projects
3.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aali309 @mwangggg @andrewazores @tthvo