Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(version): build image as quay.io/cryostat/cryostat with lowercase version tag #144

Merged
merged 16 commits into from
Nov 7, 2023
Merged

build(version): build image as quay.io/cryostat/cryostat with lowercase version tag #144

merged 16 commits into from
Nov 7, 2023

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Fixes: #124

@andrewazores andrewazores added ci build chore Refactor, rename, cleanup, etc. safe-to-test labels Nov 7, 2023
@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Nov 7, 2023
@andrewazores andrewazores removed the needs-triage Needs thorough attention from code reviewers label Nov 7, 2023
@andrewazores
Copy link
Member Author

Sample run on my fork:

https://github.com/andrewazores/cryostat3/actions/runs/6789839546/job/18457931263

Failed pushing to quay.io as expected, since my fork doesn't have the right secrets.

@andrewazores andrewazores marked this pull request as ready for review November 7, 2023 21:56
@andrewazores andrewazores requested a review from a team as a code owner November 7, 2023 21:56
ebaron
ebaron reviewed Nov 7, 2023
View reviewed changes
.github/workflows/push-ci.yaml Outdated Show resolved Hide resolved
.github/workflows/push-ci.yaml Show resolved Hide resolved
@andrewazores
Copy link
Member Author

New test run: https://github.com/andrewazores/cryostat3/actions/runs/6790922942

@andrewazores andrewazores merged commit effeb6a into cryostatio:main Nov 7, 2023
9 checks passed
@andrewazores andrewazores deleted the ci-3-dev branch November 7, 2023 23:41
This was referenced Nov 7, 2023
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebaron ebaron ebaron approved these changes

Assignees
No one assigned
Labels
build chore Refactor, rename, cleanup, etc. ci safe-to-test
Projects
No open projects
3.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Publish multiarch builds to quay.io
2 participants
@andrewazores @ebaron