fix(jmxauth): tolerate JMX auth failures at discovery, re-attempt if new matching Credentials added #329
Conversation
andrewazores
force-pushed
the
jmx-auth
branch
3 times, most recently
from
3ff7235
to
a9b0e6f
Compare
|
/build_test |
|
Workflow started at 3/20/2024, 4:40:04 PM. View Actions Run. |
|
CI build and push: All tests pass ✅ (JDK21) |
|
No OpenAPI schema changes detected. |
|
CI build and push: At least one test failed ❌ (JDK17) |
andrewazores
force-pushed
the
jmx-auth
branch
2 times, most recently
from
05ef44f
to
3379e9b
Compare
|
This PR/issue depends on:
|
|
/build_test |
|
Workflow started at 3/22/2024, 9:27:44 AM. View Actions Run. |
|
CI build and push: All tests pass ✅ (JDK21) |
|
/build_test |
|
No OpenAPI schema changes detected. |
|
Workflow started at 3/22/2024, 9:30:57 AM. View Actions Run. |
|
CI build and push: All tests pass ✅ (JDK21) |
|
CI build and push: All tests pass ✅ (JDK17) |
|
No OpenAPI schema changes detected. |
|
CI build and push: All tests pass ✅ (JDK17) |
…new matching Credentials added
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainRelated to #2
Related to #71
Depends on #337
Description of the change:
Cryostat 3 tolerates connection failures when attempting to determine newly discovered targets' JVM IDs. When new Credentials are added, Cryostat looks in the database for any targets with null JVM IDs (signifying the initial connection failure), checks if the new credential matches the target, and then re-attempts to determine the JVM hash ID and persist this update to the database.
Motivation for the change:
Prior to this change, Cryostat 3 would always try to connect to newly discovered JVMs to determine their hash IDs. If this connection attempt failed for any reason then the discovery would be ignored and the JVM would not be registered in the target database. This means that target JVMs which require JMX authentication, and/or which use JMX with TLS, may not be discoverable unless Cryostat 3 is pre-configured with the correct credentials and certificates.
JMX SSL/TLS cert handling is not implemented here. See #330.
How to manually test:
sample-app-2andsample-app-3JDP targets should now appear with ports9094and9095respectively.target.alias.contains('andrew')and credentialsadmin:adminpass123.sample-app-2:9094should now be connectable and usable in all the usual ways.sample-app-3:9095still will not be since it also requires SSL/TLS.