Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(smoketest): cleanup, add config to run without S3 #472

Merged
merged 2 commits into from
May 30, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented May 21, 2024

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Description of the change:

  1. Cleans up some service dependency declarations to be placed in the correct files so that services are easier to mix and match.
  2. Adds s3-none.yml, which is an intentionally stub-out of the S3 provider, pointing Cryostat at a nonexistent S3 service and not starting any S3 service. This would not be useful in normal circumstances but can be used to check Cryostat's behaviour if its S3 object storage goes offline or is otherwise unreachable.

How to manually test:

  1. Check out PR
  2. ./smoketest.bash -O -s none
  3. This should hang for quite a while as Cryostat repeatedly tries to check for the storage buckets it expects, but is unable to resolve the object storage container (since there is none). The smoketest should eventually bail out.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label May 21, 2024
@andrewazores andrewazores removed the needs-triage Needs thorough attention from code reviewers label May 21, 2024
@andrewazores andrewazores marked this pull request as ready for review May 21, 2024 20:22
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

4 similar comments
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@andrewazores andrewazores merged commit 72dbe66 into cryostatio:main May 30, 2024
6 of 7 checks passed
@andrewazores andrewazores deleted the smoketest-no-s3 branch May 30, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants