Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): create 2.4.0 versioned images copy, update references in latest guides #149

Conversation

andrewazores
Copy link
Member

Related to #142

Copy images (screenshots) from 2.3.0 subdirectory to new 2.4.0 directory, and update all references in "latest" version (2.4.0 prep content") to point to these versions instead.

Further PRs to the 142 branch will replace these images with updated screenshots as necessary reflecting what 2.4.0 looks like.

@andrewazores andrewazores added the chore Refactor, rename, cleanup, etc. label Nov 2, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the view report option is removed now?
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right - like I said in the PR description, I am just creating the copies here. Correcting the images (and guide texts) can be done in follow-up PRs. Otherwise, the entire website has to be updated at once in one giant PR and nobody will be able to review it thoroughly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one too?

@aali309
Copy link
Contributor

aali309 commented Nov 2, 2023

Other than the images, LGTM

@andrewazores andrewazores merged commit d936829 into cryostatio:142-story-update-screenshots-for-240 Nov 6, 2023
2 checks passed
@andrewazores andrewazores deleted the versioned-screenshots-240 branch November 6, 2023 14:34
andrewazores added a commit that referenced this pull request Nov 16, 2023
andrewazores added a commit that referenced this pull request Dec 11, 2023
* chore(get-started): update screenshots (#145)

* chore(release): create 2.4.0 versioned images copy, update references in latest guides (#149)

* chore(guides): guides/_subsections/automated-analysis.md screenshots updated (#165)

* chore(guides): updated dashboard-layout-setastemplate screenshot (#166)

* chore(guides): guides/_subsections/view-in-grafana.md screenshot updated (#168)

* updated select target application screenshot (#167)

---------

Co-authored-by: Atif Ali <56743004+aali309@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants